FEATURE: Modernize package for Neos 7.3 and newer #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we moved to esbuild we needed some adjustments for the styling. Additionally this change fixes an issue with the MapStyles.
markusguenther
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the package to ensure compatibility with Neos 7.3 and newer versions. As part of this, the project now uses the
esbuild-based stack introduced inNeos.UI8.3, improving the build process and performance.Google Maps Library:
The current Google Maps library is outdated. While replacing it with @react-google-maps/api would be a more modern solution, I've opted to keep the changes minimal to reduce potential impact. This should maintain stability while ensuring compatibility with the new setup.
Outcome:
The Editor should look more or less the same and behave the same way.
We have some warnings in the console regarding the outdated Google Maps Library, but that's for another PR maybe.